mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()
authorMoYuanhao <moyuanhao3676@163.com>
Wed, 6 Nov 2024 07:10:35 +0000 (15:10 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 9 Nov 2024 17:09:07 +0000 (09:09 -0800)
The variable has already been assigned in the subflow_create_ctx(),
So we don't need to reassign this variable in the subflow_ulp_clone().

Signed-off-by: MoYuanhao <moyuanhao3676@163.com>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20241106071035.2591-1-moyuanhao3676@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/subflow.c

index 07352b1..fd021cf 100644 (file)
@@ -2049,7 +2049,6 @@ static void subflow_ulp_clone(const struct request_sock *req,
        new_ctx->tcp_state_change = old_ctx->tcp_state_change;
        new_ctx->tcp_error_report = old_ctx->tcp_error_report;
        new_ctx->rel_write_seq = 1;
-       new_ctx->tcp_sock = newsk;
 
        if (subflow_req->mp_capable) {
                /* see comments in subflow_syn_recv_sock(), MPTCP connection