pinctrl: apple: make apple_gpio_get_direction more readable

Try to make this more readable by not using a long line with
a ternary operator.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20211121165642.27883-7-joey.gouly@arm.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c
index bd7f281..fba2d4e 100644 (file)
--- a/drivers/pinctrl/pinctrl-apple-gpio.c
+++ b/drivers/pinctrl/pinctrl-apple-gpio.c
@@ -194,8 +194,9 @@ static int apple_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
        struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip);
        unsigned int reg = apple_gpio_get_reg(pctl, offset);
 
-       return (FIELD_GET(REG_GPIOx_MODE, reg) == REG_GPIOx_OUT) ?
-                      GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN;
+       if (FIELD_GET(REG_GPIOx_MODE, reg) == REG_GPIOx_OUT)
+               return GPIO_LINE_DIRECTION_OUT;
+       return GPIO_LINE_DIRECTION_IN;
 }
 
 static int apple_gpio_get(struct gpio_chip *chip, unsigned offset)