selftests/powerpc: Remove the path after initialization.
authorzhang jiao <zhangjiao2@cmss.chinamobile.com>
Mon, 30 Sep 2024 01:27:57 +0000 (09:27 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 14 Nov 2024 11:41:00 +0000 (22:41 +1100)
If there were no anamolies noted, then we can simply remove the log file
and return, but only after the path variable has been initialized.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20240930012757.2395-1-zhangjiao2@cmss.chinamobile.com
tools/testing/selftests/powerpc/mm/tlbie_test.c

index 48344a7..35f0098 100644 (file)
@@ -313,16 +313,16 @@ static inline void end_verification_log(unsigned int tid, unsigned nr_anamolies)
 
        fclose(f);
 
-       if (nr_anamolies == 0) {
-               remove(path);
-               return;
-       }
-
        sprintf(logfile, logfilename, tid);
        strcpy(path, logdir);
        strcat(path, separator);
        strcat(path, logfile);
 
+       if (nr_anamolies == 0) {
+               remove(path);
+               return;
+       }
+
        printf("Thread %02d chunk has %d corrupted words. For details check %s\n",
                tid, nr_anamolies, path);
 }