ASoC: SOF: mediatek: initialize panic_info to zero
authorYC Hung <yc.hung@mediatek.com>
Tue, 13 Dec 2022 11:56:17 +0000 (19:56 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 13 Dec 2022 18:16:32 +0000 (18:16 +0000)
Coverity spotted that panic_info is not initialized to zero in
mtk_adsp_dump. Using uninitialized value panic_info.linenum when
calling snd_sof_get_status. Fix this coverity by initializing
panic_info struct as zero.

Signed-off-by: YC Hung <yc.hung@mediatek.com>
Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
Link: https://lore.kernel.org/r/20221213115617.25086-1-yc.hung@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/mediatek/mtk-adsp-common.c

index 1e0769c..de8dbe2 100644 (file)
@@ -60,7 +60,7 @@ void mtk_adsp_dump(struct snd_sof_dev *sdev, u32 flags)
 {
        char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;
        struct sof_ipc_dsp_oops_xtensa xoops;
-       struct sof_ipc_panic_info panic_info;
+       struct sof_ipc_panic_info panic_info = {};
        u32 stack[MTK_ADSP_STACK_DUMP_SIZE];
        u32 status;