io_uring: IORING_OP_WRITE needs hash_reg_file set
authorJens Axboe <axboe@kernel.dk>
Tue, 31 Aug 2021 01:37:41 +0000 (19:37 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 31 Aug 2021 17:45:30 +0000 (11:45 -0600)
During some testing, it became evident that using IORING_OP_WRITE doesn't
hash buffered writes like the other writes commands do. That's simply
an oversight, and can cause performance regressions when doing buffered
writes with this command.

Correct that and add the flag, so that buffered writes are correctly
hashed when using the non-iovec based write command.

Cc: stable@vger.kernel.org
Fixes: 3a6820f2bb8a ("io_uring: add non-vectored read/write commands")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 7cc458e..473a977 100644 (file)
@@ -995,6 +995,7 @@ static const struct io_op_def io_op_defs[] = {
        },
        [IORING_OP_WRITE] = {
                .needs_file             = 1,
+               .hash_reg_file          = 1,
                .unbound_nonreg_file    = 1,
                .pollout                = 1,
                .plug                   = 1,