bridge: br_arp_nd_proxy: set icmp6_router if neigh has NTF_ROUTER
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Tue, 25 Sep 2018 21:39:14 +0000 (14:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Sep 2018 03:33:21 +0000 (20:33 -0700)
Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_arp_nd_proxy.c

index 2cf7716..d42e390 100644 (file)
@@ -311,7 +311,7 @@ static void br_nd_send(struct net_bridge *br, struct net_bridge_port *p,
        /* Neighbor Advertisement */
        memset(na, 0, sizeof(*na) + na_olen);
        na->icmph.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
-       na->icmph.icmp6_router = 0; /* XXX: should be 1 ? */
+       na->icmph.icmp6_router = (n->flags & NTF_ROUTER) ? 1 : 0;
        na->icmph.icmp6_override = 1;
        na->icmph.icmp6_solicited = 1;
        na->target = ns->target;