usb: chipidea: tegra: Stop managing PHY's power
authorDmitry Osipenko <digetx@gmail.com>
Mon, 6 Jan 2020 01:34:13 +0000 (04:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 15:21:58 +0000 (16:21 +0100)
Tegra's USB PHY driver now provides generic PHY init/shutdown callbacks
and thus the custom PHY management could be removed from Tegra-specific
part of the ChipIdea driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20200106013416.9604-18-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci_hdrc_tegra.c

index 0c9911d..7455df0 100644 (file)
@@ -83,13 +83,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
                return err;
        }
 
-       /*
-        * Tegra's USB PHY driver doesn't implement optional phy_init()
-        * hook, so we have to power on UDC controller before ChipIdea
-        * driver initialization kicks in.
-        */
-       usb_phy_set_suspend(udc->phy, 0);
-
        /* setup and register ChipIdea HDRC device */
        udc->data.name = "tegra-udc";
        udc->data.flags = soc->flags;
@@ -109,7 +102,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
        return 0;
 
 fail_power_off:
-       usb_phy_set_suspend(udc->phy, 1);
        clk_disable_unprepare(udc->clk);
        return err;
 }
@@ -119,7 +111,6 @@ static int tegra_udc_remove(struct platform_device *pdev)
        struct tegra_udc *udc = platform_get_drvdata(pdev);
 
        ci_hdrc_remove_device(udc->dev);
-       usb_phy_set_suspend(udc->phy, 1);
        clk_disable_unprepare(udc->clk);
 
        return 0;