net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flags
authorSean Anderson <sean.anderson@linux.dev>
Thu, 22 Aug 2024 15:40:58 +0000 (11:40 -0400)
committerJakub Kicinski <kuba@kernel.org>
Mon, 26 Aug 2024 16:52:02 +0000 (09:52 -0700)
Contrary to the comment, we don't have to inform the net subsystem.

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240822154059.1066595-5-sean.anderson@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c

index f612adb..5c4a594 100644 (file)
@@ -439,11 +439,6 @@ static void axienet_set_multicast_list(struct net_device *ndev)
 
        if (ndev->flags & (IFF_ALLMULTI | IFF_PROMISC) ||
            netdev_mc_count(ndev) > XAE_MULTICAST_CAM_TABLE_NUM) {
-               /* We must make the kernel realize we had to move into
-                * promiscuous mode. If it was a promiscuous mode request
-                * the flag is already set. If not we set it.
-                */
-               ndev->flags |= IFF_PROMISC;
                reg = axienet_ior(lp, XAE_FMI_OFFSET);
                reg |= XAE_FMI_PM_MASK;
                axienet_iow(lp, XAE_FMI_OFFSET, reg);