overflow-arith: begin to add support for overflow builtin functions
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Fri, 16 Oct 2015 09:32:42 +0000 (11:32 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Oct 2015 09:49:35 +0000 (02:49 -0700)
The idea of the overflow-arith.h header is to collect overflow checking
functions in one central place.

If gcc compiler supports the __builtin_overflow_* builtins we use them
because they might give better performance, otherwise the code falls
back to normal overflow checking functions.

The builtin_overflow functions are supported by gcc-5 and clang. The
matter of supporting clang is to just provide a corresponding
CC_HAVE_BUILTIN_OVERFLOW, because the specific overflow checking builtins
don't differ between gcc and clang.

I just provide overflow_usub function here as I intend this to get merged
into net, more functions will definitely follow as they are needed.

Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/compiler-gcc.h
include/linux/overflow-arith.h [new file with mode: 0644]

index dfaa7b3..82c159e 100644 (file)
 #define KASAN_ABI_VERSION 3
 #endif
 
+#if GCC_VERSION >= 50000
+#define CC_HAVE_BUILTIN_OVERFLOW
+#endif
+
 #endif /* gcc version >= 40000 specific checks */
 
 #if !defined(__noclone)
diff --git a/include/linux/overflow-arith.h b/include/linux/overflow-arith.h
new file mode 100644 (file)
index 0000000..e12ccf8
--- /dev/null
@@ -0,0 +1,18 @@
+#pragma once
+
+#include <linux/kernel.h>
+
+#ifdef CC_HAVE_BUILTIN_OVERFLOW
+
+#define overflow_usub __builtin_usub_overflow
+
+#else
+
+static inline bool overflow_usub(unsigned int a, unsigned int b,
+                                unsigned int *res)
+{
+       *res = a - b;
+       return *res > a ? true : false;
+}
+
+#endif