scsi: qla2xxx: make 1-bit bit-fields unsigned int
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Apr 2020 10:20:13 +0000 (11:20 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 30 Apr 2020 02:10:40 +0000 (22:10 -0400)
The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
which is not recommended as the representation is an implementation defined
behaviour.  Fix this by making the bit-fields unsigned ints.

Link: https://lore.kernel.org/r/20200428102013.1040598-1-colin.king@canonical.com
Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_def.h

index daa9e93..172ea4e 100644 (file)
@@ -4248,8 +4248,8 @@ struct qla_hw_data {
        int             fw_dump_reading;
        void            *mpi_fw_dump;
        u32             mpi_fw_dump_len;
-       int             mpi_fw_dump_reading:1;
-       int             mpi_fw_dumped:1;
+       unsigned int    mpi_fw_dump_reading:1;
+       unsigned int    mpi_fw_dumped:1;
        int             prev_minidump_failed;
        dma_addr_t      eft_dma;
        void            *eft;