drm/amdgpu: validate wait_for_idle before function call
authorSunil Khatri <sunil.khatri@amd.com>
Wed, 9 Oct 2024 13:14:52 +0000 (18:44 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 22 Oct 2024 21:50:39 +0000 (17:50 -0400)
Before making a function call to wait_for_idle,
validate the function pointer like we do in sw_init.

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index 754beec..b377bd9 100644 (file)
@@ -2240,9 +2240,12 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev,
                if (!adev->ip_blocks[i].status.valid)
                        continue;
                if (adev->ip_blocks[i].version->type == block_type) {
-                       r = adev->ip_blocks[i].version->funcs->wait_for_idle(&adev->ip_blocks[i]);
-                       if (r)
-                               return r;
+                       if (adev->ip_blocks[i].version->funcs->wait_for_idle) {
+                               r = adev->ip_blocks[i].version->funcs->wait_for_idle(
+                                                               &adev->ip_blocks[i]);
+                               if (r)
+                                       return r;
+                       }
                        break;
                }
        }