serial: uartps: Do not initialize field to zero again
authorMichal Simek <michal.simek@xilinx.com>
Mon, 3 Sep 2018 13:10:50 +0000 (15:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2018 14:07:22 +0000 (16:07 +0200)
Writing zero and NULLs to already initialized fields is not needed.
Remove this additional writes.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/xilinx_uartps.c

index fdb984b..edb9c2a 100644 (file)
@@ -1503,15 +1503,12 @@ static int cdns_uart_probe(struct platform_device *pdev)
 
        /* At this point, we've got an empty uart_port struct, initialize it */
        spin_lock_init(&port->lock);
-       port->membase   = NULL;
-       port->irq       = 0;
        port->type      = PORT_UNKNOWN;
        port->iotype    = UPIO_MEM32;
        port->flags     = UPF_BOOT_AUTOCONF;
        port->ops       = &cdns_uart_ops;
        port->fifosize  = CDNS_UART_FIFO_SIZE;
        port->line      = id;
-       port->dev       = NULL;
 
        /*
         * Register the port.