KVM: x86/mmu: Drop new_spte local variable from restore_acc_track_spte()
authorDavid Matlack <dmatlack@google.com>
Wed, 19 Jan 2022 23:07:30 +0000 (23:07 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 10 Feb 2022 18:50:39 +0000 (13:50 -0500)
The new_spte local variable is unnecessary. Deleting it can save a line
of code and simplify the remaining lines a bit.

No functional change intended.

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20220119230739.2234394-10-dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c

index 51b9cb9..b92f062 100644 (file)
@@ -648,16 +648,15 @@ static u64 mmu_spte_get_lockless(u64 *sptep)
 /* Restore an acc-track PTE back to a regular PTE */
 static u64 restore_acc_track_spte(u64 spte)
 {
-       u64 new_spte = spte;
        u64 saved_bits = (spte >> SHADOW_ACC_TRACK_SAVED_BITS_SHIFT)
                         & SHADOW_ACC_TRACK_SAVED_BITS_MASK;
 
-       new_spte &= ~shadow_acc_track_mask;
-       new_spte &= ~(SHADOW_ACC_TRACK_SAVED_BITS_MASK <<
-                     SHADOW_ACC_TRACK_SAVED_BITS_SHIFT);
-       new_spte |= saved_bits;
+       spte &= ~shadow_acc_track_mask;
+       spte &= ~(SHADOW_ACC_TRACK_SAVED_BITS_MASK <<
+                 SHADOW_ACC_TRACK_SAVED_BITS_SHIFT);
+       spte |= saved_bits;
 
-       return new_spte;
+       return spte;
 }
 
 /* Returns the Accessed status of the PTE and resets it at the same time. */