gpu: nova-core: make formatting compatible with rust tree
authorAlice Ryhl <aliceryhl@google.com>
Mon, 17 Nov 2025 10:39:17 +0000 (10:39 +0000)
committerAlice Ryhl <aliceryhl@google.com>
Mon, 17 Nov 2025 12:56:36 +0000 (12:56 +0000)
Commit 38b7cc448a5b ("gpu: nova-core: implement Display for Spec") in
drm-rust-next introduced some usage of the Display trait, but the
Display trait is being modified in the rust tree this cycle. Thus, to
avoid conflicts with the Rust tree, tweak how the formatting machinery
is used in a way where it works both with and without the changes in the
Rust tree.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Alexandre Courbot <acourbot@nvidia.com>
Link: https://patch.msgid.link/20251117-nova-fmt-rust-v1-1-651ca28cd98f@google.com
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
drivers/gpu/nova-core/gpu.rs
drivers/gpu/nova-core/gsp/fw.rs

index 19755af..629c9d2 100644 (file)
@@ -227,13 +227,12 @@ impl TryFrom<regs::NV_PMC_BOOT_42> for Spec {
 
 impl fmt::Display for Spec {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(
-            f,
+        f.write_fmt(fmt!(
             "Chipset: {}, Architecture: {:?}, Revision: {}",
             self.chipset,
             self.chipset.arch(),
             self.revision
-        )
+        ))
     }
 }
 
index 8deec5e..abffd6b 100644 (file)
@@ -6,13 +6,11 @@ mod r570_144;
 // Alias to avoid repeating the version number with every use.
 use r570_144 as bindings;
 
-use core::{
-    fmt,
-    ops::Range, //
-};
+use core::ops::Range;
 
 use kernel::{
     dma::CoherentAllocation,
+    fmt,
     prelude::*,
     ptr::{
         Alignable,