fuse: don't ignore errors from fuse_writepages_fill()
authorVasily Averin <vvs@virtuozzo.com>
Thu, 25 Jun 2020 09:39:51 +0000 (12:39 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Tue, 14 Jul 2020 12:45:42 +0000 (14:45 +0200)
fuse_writepages() ignores some errors taken from fuse_writepages_fill() I
believe it is a bug: if .writepages is called with WB_SYNC_ALL it should
either guarantee that all data was successfully saved or return error.

Fixes: 26d614df1da9 ("fuse: Implement writepages callback")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/file.c

index a6a5aef..9895ce2 100644 (file)
@@ -2165,10 +2165,8 @@ static int fuse_writepages(struct address_space *mapping,
 
        err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data);
        if (data.wpa) {
-               /* Ignore errors if we can write at least one page */
                WARN_ON(!data.wpa->ia.ap.num_pages);
                fuse_writepages_send(&data);
-               err = 0;
        }
        if (data.ff)
                fuse_file_put(data.ff, false, false);