octeon_ep: unlock the correct lock on error path
authorDan Carpenter <error27@gmail.com>
Wed, 29 Mar 2023 06:51:37 +0000 (09:51 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Mar 2023 04:39:35 +0000 (21:39 -0700)
The h and the f letters are swapped so it unlocks the wrong lock.

Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/251aa2a2-913e-4868-aac9-0a90fc3eeeda@kili.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c

index a4ee6f3..035ead7 100644 (file)
@@ -167,7 +167,7 @@ int octep_ctrl_mbox_send(struct octep_ctrl_mbox *mbox, struct octep_ctrl_mbox_ms
        ci = readl(q->hw_cons);
 
        if (octep_ctrl_mbox_circq_space(pi, ci, q->sz) < (msg->hdr.s.sz + mbox_hdr_sz)) {
-               mutex_unlock(&mbox->f2hq_lock);
+               mutex_unlock(&mbox->h2fq_lock);
                return -EAGAIN;
        }