drm/i915/pps: rename vlv_pps_init() to vlv_pps_port_enable_unlocked()
authorJani Nikula <jani.nikula@intel.com>
Wed, 18 Sep 2024 17:47:47 +0000 (20:47 +0300)
committerJani Nikula <jani.nikula@intel.com>
Thu, 19 Sep 2024 07:48:53 +0000 (10:48 +0300)
Follow the naming for vlv_pps_port_disable(), as these are counterparts,
and add _unlocked suffix as it assumes the pps lock is held.

v2: Add _unlocked suffix (Ville)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3b21141025a5e1e67f28bbe67a82a7008fd3f415.1726681620.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/g4x_dp.c
drivers/gpu/drm/i915/display/intel_pps.c
drivers/gpu/drm/i915/display/intel_pps.h

index e3db1cb..162802c 100644 (file)
@@ -690,7 +690,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
 
        with_intel_pps_lock(intel_dp, wakeref) {
                if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
-                       vlv_pps_init(encoder, pipe_config);
+                       vlv_pps_port_enable_unlocked(encoder, pipe_config);
 
                intel_dp_enable_port(intel_dp, pipe_config);
 
index 465a555..63bae4c 100644 (file)
@@ -1227,8 +1227,9 @@ void vlv_pps_pipe_reset(struct intel_dp *intel_dp)
                intel_dp->pps.vlv_active_pipe = vlv_active_pipe(intel_dp);
 }
 
-void vlv_pps_init(struct intel_encoder *encoder,
-                 const struct intel_crtc_state *crtc_state)
+/* Call on all DP, not just eDP */
+void vlv_pps_port_enable_unlocked(struct intel_encoder *encoder,
+                                 const struct intel_crtc_state *crtc_state)
 {
        struct intel_display *display = to_intel_display(encoder);
        struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
index 795e25c..5b3eb7f 100644 (file)
@@ -47,8 +47,8 @@ void intel_pps_reset_all(struct intel_display *display);
 
 void vlv_pps_pipe_init(struct intel_dp *intel_dp);
 void vlv_pps_pipe_reset(struct intel_dp *intel_dp);
-void vlv_pps_init(struct intel_encoder *encoder,
-                 const struct intel_crtc_state *crtc_state);
+void vlv_pps_port_enable_unlocked(struct intel_encoder *encoder,
+                                 const struct intel_crtc_state *crtc_state);
 void vlv_pps_port_disable(struct intel_encoder *encoder,
                          const struct intel_crtc_state *crtc_state);