mfd: dln2: Fix double put in dln2_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Mon, 25 Sep 2023 02:41:33 +0000 (10:41 +0800)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 10:02:13 +0000 (10:02 +0000)
The dln2_free() already contains usb_put_dev(). Therefore,
the redundant usb_put_dev() before dln2_free() may lead to
a double free.

Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230925024134.9683-1-dinghao.liu@zju.edu.cn
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/dln2.c

index c751043..fbbe82c 100644 (file)
@@ -826,7 +826,6 @@ out_stop_rx:
        dln2_stop_rx_urbs(dln2);
 
 out_free:
-       usb_put_dev(dln2->usb_dev);
        dln2_free(dln2);
 
        return ret;