soc: sifive: ccache: fix missing free_irq() in error path in sifive_ccache_init()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 18 Oct 2022 02:31:48 +0000 (10:31 +0800)
committerConor Dooley <conor.dooley@microchip.com>
Wed, 9 Nov 2022 22:01:31 +0000 (22:01 +0000)
Add missing free_irq() before return error from sifive_ccache_init().

Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/soc/sifive/sifive_ccache.c

index 25019c1..98269d0 100644 (file)
@@ -240,7 +240,7 @@ static int __init sifive_ccache_init(void)
                                 NULL);
                if (rc) {
                        pr_err("Could not request IRQ %d\n", g_irq[i]);
-                       goto err_unmap;
+                       goto err_free_irq;
                }
        }
 
@@ -254,6 +254,9 @@ static int __init sifive_ccache_init(void)
 #endif
        return 0;
 
+err_free_irq:
+       while (--i >= 0)
+               free_irq(g_irq[i], NULL);
 err_unmap:
        iounmap(ccache_base);
        return rc;