USB: serial: iuu_phoenix: remove unused buffer from open
authorJohan Hovold <johan@kernel.org>
Thu, 12 Jan 2017 13:56:15 +0000 (14:56 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 16 Jan 2017 15:38:56 +0000 (16:38 +0100)
Remove code that allocated but never used a buffer during open.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/iuu_phoenix.c

index d57fb51..030390f 100644 (file)
@@ -976,7 +976,6 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port)
 {
        struct usb_serial *serial = port->serial;
        struct device *dev = &port->dev;
-       u8 *buf;
        int result;
        int baud;
        u32 actual;
@@ -991,20 +990,8 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port)
        usb_clear_halt(serial->dev, port->write_urb->pipe);
        usb_clear_halt(serial->dev, port->read_urb->pipe);
 
-       buf = kmalloc(10, GFP_KERNEL);
-       if (buf == NULL)
-               return -ENOMEM;
-
        priv->poll = 0;
 
-       /* initialize writebuf */
-#define FISH(a, b, c, d) do { \
-       result = usb_control_msg(port->serial->dev,     \
-                               usb_rcvctrlpipe(port->serial->dev, 0),  \
-                               b, a, c, d, buf, 1, 1000); \
-       dev_dbg(dev, "0x%x:0x%x:0x%x:0x%x  %d - %x\n", a, b, c, d, result, \
-                               buf[0]); } while (0);
-
 #define SOUP(a, b, c, d)  do { \
        result = usb_control_msg(port->serial->dev,     \
                                usb_sndctrlpipe(port->serial->dev, 0),  \
@@ -1017,7 +1004,7 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port)
        /* sprintf(buf ,"%c%c%c%c",0x03,0x02,0x02,0x0); */
 
        SOUP(0x03, 0x02, 0x02, 0x0);
-       kfree(buf);
+
        iuu_led(port, 0xF000, 0xF000, 0, 0xFF);
        iuu_uart_on(port);
        if (boost < 100)