tty: amiserial: use bool and rename overrun flag in receive_chars()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 21 Nov 2023 09:22:47 +0000 (10:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Nov 2023 07:23:17 +0000 (07:23 +0000)
'oe' is a yes-no flag, switch it to boolean. And rename to overrun. All
for the code to be more obvious.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231121092258.9334-7-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/amiserial.c

index b9580bb..a80f059 100644 (file)
@@ -180,7 +180,7 @@ static void receive_chars(struct serial_state *info)
        int serdatr;
        unsigned char ch, flag;
        struct  async_icount *icount;
-       int oe = 0;
+       bool overrun = false;
 
        icount = &info->icount;
 
@@ -251,11 +251,11 @@ static void receive_chars(struct serial_state *info)
             * reported immediately, and doesn't
             * affect the current character
             */
-            oe = 1;
+            overrun = true;
          }
        }
        tty_insert_flip_char(&info->tport, ch, flag);
-       if (oe == 1)
+       if (overrun)
                tty_insert_flip_char(&info->tport, 0, TTY_OVERRUN);
        tty_flip_buffer_push(&info->tport);
 }