tsnep: Add missing of_node_put() in tsnep_mdio_init()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 24 Nov 2021 08:40:48 +0000 (16:40 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 26 Nov 2021 03:20:34 +0000 (19:20 -0800)
The node pointer is returned by of_get_child_by_name() with
refcount incremented in tsnep_mdio_init(). Calling of_node_put()
to aovid the refcount leak in tsnep_mdio_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211124084048.175456-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/engleder/tsnep_main.c

index 955565a..904f330 100644 (file)
@@ -1089,9 +1089,10 @@ static int tsnep_mdio_init(struct tsnep_adapter *adapter)
        adapter->mdiobus->phy_mask = 0x0000001;
 
        retval = of_mdiobus_register(adapter->mdiobus, np);
+
+out:
        if (np)
                of_node_put(np);
-out:
 
        return retval;
 }