ALSA: opti9xx: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 2 Aug 2018 20:41:55 +0000 (15:41 -0500)
committerTakashi Iwai <tiwai@suse.de>
Fri, 3 Aug 2018 10:21:01 +0000 (12:21 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 402016 ("Missing break in switch")
Addresses-Coverity-ID: 1056542 ("Missing break in switch")
Addresses-Coverity-ID: 1339579 ("Missing break in switch")
Addresses-Coverity-ID: 1369526 ("Missing break in switch")
Addresses-Coverity-ID: 1369529 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/opti9xx/miro.c

index 8894c7c..c6136c6 100644 (file)
@@ -176,10 +176,13 @@ static int aci_busy_wait(struct snd_miro_aci *aci)
                        switch (timeout-ACI_MINTIME) {
                        case 0 ... 9:
                                out /= 10;
+                               /* fall through */
                        case 10 ... 19:
                                out /= 10;
+                               /* fall through */
                        case 20 ... 30:
                                out /= 10;
+                               /* fall through */
                        default:
                                set_current_state(TASK_UNINTERRUPTIBLE);
                                schedule_timeout(out);
@@ -834,6 +837,7 @@ static unsigned char snd_miro_read(struct snd_miro *chip,
                        retval = inb(chip->mc_base + 9);
                        break;
                }
+               /* fall through */
 
        case OPTi9XX_HW_82C929:
                retval = inb(chip->mc_base + reg);
@@ -863,6 +867,7 @@ static void snd_miro_write(struct snd_miro *chip, unsigned char reg,
                        outb(value, chip->mc_base + 9);
                        break;
                }
+               /* fall through */
 
        case OPTi9XX_HW_82C929:
                outb(value, chip->mc_base + reg);