drm/hisilicon: Remove drm_dev_put in hibmc
authorTian Tao <tiantao6@hisilicon.com>
Tue, 22 Dec 2020 11:55:56 +0000 (19:55 +0800)
committerTian Tao <tiantao6@hisilicon.com>
Wed, 23 Dec 2020 13:20:28 +0000 (08:20 -0500)
Hibmc use the devm_drm_dev_alloc function in hibmc_pci_probe, if
hibmc_pci_probe returns non-zero, devm_drm_dev_alloc will call
devm_drm_dev_init, which will call devm_drm_dev_init_release to
release drm_dev_put. There is no need for hibmc to call
drm_dev_put separately.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1608638156-7879-1-git-send-email-tiantao6@hisilicon.com
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

index 7159018..0d4e902 100644 (file)
@@ -332,13 +332,13 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
        ret = pcim_enable_device(pdev);
        if (ret) {
                drm_err(dev, "failed to enable pci device: %d\n", ret);
-               goto err_free;
+               goto err_return;
        }
 
        ret = hibmc_load(dev);
        if (ret) {
                drm_err(dev, "failed to load hibmc: %d\n", ret);
-               goto err_free;
+               goto err_return;
        }
 
        ret = drm_dev_register(dev, 0);
@@ -354,9 +354,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
 
 err_unload:
        hibmc_unload(dev);
-err_free:
-       drm_dev_put(dev);
-
+err_return:
        return ret;
 }