rtc: pcf85063: silence cppcheck warning
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 7 Nov 2021 22:53:48 +0000 (23:53 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 9 Nov 2021 23:45:35 +0000 (00:45 +0100)
cppcheck warnings: (new ones prefixed by >>)

>> drivers/rtc/rtc-pcf85063.c:292:40: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
     status = status & PCF85063_REG_SC_OS ? RTC_VL_DATA_INVALID : 0;

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211107225349.110707-1-alexandre.belloni@bootlin.com
drivers/rtc/rtc-pcf85063.c

index 4a70d6b..15e50bb 100644 (file)
@@ -299,7 +299,7 @@ static int pcf85063_ioctl(struct device *dev, unsigned int cmd,
                if (ret < 0)
                        return ret;
 
-               status = status & PCF85063_REG_SC_OS ? RTC_VL_DATA_INVALID : 0;
+               status = (status & PCF85063_REG_SC_OS) ? RTC_VL_DATA_INVALID : 0;
 
                return put_user(status, (unsigned int __user *)arg);