net: greth: Utilize of_get_mac_address()
authorTobias Klauser <tklauser@distanz.ch>
Tue, 21 Mar 2017 10:24:38 +0000 (11:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Mar 2017 19:00:39 +0000 (12:00 -0700)
Do not open code getting the MAC address exclusively from the
"local-mac-address" property, but instead use of_get_mac_address() which
looks up the MAC address using the 3 typical property names.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aeroflex/greth.c

index 9f7422a..d8e133c 100644 (file)
@@ -34,6 +34,7 @@
 #include <linux/crc32.h>
 #include <linux/mii.h>
 #include <linux/of_device.h>
+#include <linux/of_net.h>
 #include <linux/of_platform.h>
 #include <linux/slab.h>
 #include <asm/cacheflush.h>
@@ -1454,11 +1455,10 @@ static int greth_of_probe(struct platform_device *ofdev)
                        break;
        }
        if (i == 6) {
-               const unsigned char *addr;
-               int len;
-               addr = of_get_property(ofdev->dev.of_node, "local-mac-address",
-                                       &len);
-               if (addr != NULL && len == 6) {
+               const u8 *addr;
+
+               addr = of_get_mac_address(ofdev->dev.of_node);
+               if (addr) {
                        for (i = 0; i < 6; i++)
                                macaddr[i] = (unsigned int) addr[i];
                } else {