backlight: hx8357: Make use of dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 1 Feb 2024 14:47:44 +0000 (16:47 +0200)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 09:03:28 +0000 (09:03 +0000)
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20240201144951.294215-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/hx8357.c

index 81d0984..70a6275 100644 (file)
@@ -579,10 +579,8 @@ static int hx8357_probe(struct spi_device *spi)
                return -ENOMEM;
 
        ret = spi_setup(spi);
-       if (ret < 0) {
-               dev_err(&spi->dev, "SPI setup failed.\n");
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "SPI setup failed.\n");
 
        lcd->spi = spi;
 
@@ -617,10 +615,8 @@ static int hx8357_probe(struct spi_device *spi)
        hx8357_lcd_reset(lcdev);
 
        ret = init_fn(lcdev);
-       if (ret) {
-               dev_err(&spi->dev, "Couldn't initialize panel\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Couldn't initialize panel\n");
 
        dev_info(&spi->dev, "Panel probed\n");