media: platform: Remove unnecessary print function dev_err()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 16 Mar 2022 00:14:11 +0000 (01:14 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 18 Mar 2022 05:05:43 +0000 (06:05 +0100)
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:119:2-9:
line 119 is redundant because platform_get_irq() already prints an error
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c:103:2-9:
line 103 is redundant because platform_get_irq() already prints an error

Link: https://lore.kernel.org/linux-media/20220316001411.80167-1-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c

index 48dad9b..df7b25e 100644 (file)
@@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
                return 0;
 
        dev->dec_irq = platform_get_irq(pdev, 0);
-       if (dev->dec_irq < 0) {
-               dev_err(&pdev->dev, "failed to get irq number");
+       if (dev->dec_irq < 0)
                return dev->dec_irq;
-       }
 
        irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
        ret = devm_request_irq(&pdev->dev, dev->dec_irq,
index 60da596..14bed2b 100644 (file)
@@ -101,10 +101,8 @@ static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev)
        int ret;
 
        dev->dec_irq = platform_get_irq(pdev, 0);
-       if (dev->dec_irq < 0) {
-               dev_err(&pdev->dev, "Failed to get irq resource");
+       if (dev->dec_irq < 0)
                return dev->dec_irq;
-       }
 
        irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
        ret = devm_request_irq(&pdev->dev, dev->dec_irq,