drm/i915/gmbus: move some local bus variables within loops
authorJani Nikula <jani.nikula@intel.com>
Fri, 4 Mar 2022 10:14:25 +0000 (12:14 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 7 Mar 2022 09:23:48 +0000 (11:23 +0200)
Limit the scope.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220304101426.1891347-1-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_gmbus.c

index 2bb3494..8f26528 100644 (file)
@@ -868,7 +868,6 @@ static const struct i2c_lock_operations gmbus_lock_ops = {
 int intel_gmbus_setup(struct drm_i915_private *dev_priv)
 {
        struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
-       struct intel_gmbus *bus;
        unsigned int pin;
        int ret;
 
@@ -886,6 +885,7 @@ int intel_gmbus_setup(struct drm_i915_private *dev_priv)
 
        for (pin = 0; pin < ARRAY_SIZE(dev_priv->gmbus); pin++) {
                const struct gmbus_pin *gmbus_pin;
+               struct intel_gmbus *bus;
 
                gmbus_pin = get_gmbus_pin(dev_priv, pin);
                if (!gmbus_pin)
@@ -978,10 +978,11 @@ bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter)
 
 void intel_gmbus_teardown(struct drm_i915_private *dev_priv)
 {
-       struct intel_gmbus *bus;
        unsigned int pin;
 
        for (pin = 0; pin < ARRAY_SIZE(dev_priv->gmbus); pin++) {
+               struct intel_gmbus *bus;
+
                bus = dev_priv->gmbus[pin];
                if (!bus)
                        continue;