ata: pata_ftide010: Remove unneeded ERROR check before clk_disable_unprepare
authorWan Jiabing <wanjiabing@vivo.com>
Fri, 13 May 2022 07:55:54 +0000 (15:55 +0800)
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>
Mon, 16 May 2022 11:22:37 +0000 (20:22 +0900)
ERROR check is already in clk_disable() and clk_unprepare() by using
IS_ERR_OR_NULL. Remove unneeded ERROR check for ftide->pclk here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
drivers/ata/pata_ftide010.c

index 2e35505..0117df0 100644 (file)
@@ -536,8 +536,8 @@ static int pata_ftide010_probe(struct platform_device *pdev)
        return 0;
 
 err_dis_clk:
-       if (!IS_ERR(ftide->pclk))
-               clk_disable_unprepare(ftide->pclk);
+       clk_disable_unprepare(ftide->pclk);
+
        return ret;
 }
 
@@ -547,8 +547,7 @@ static int pata_ftide010_remove(struct platform_device *pdev)
        struct ftide010 *ftide = host->private_data;
 
        ata_host_detach(ftide->host);
-       if (!IS_ERR(ftide->pclk))
-               clk_disable_unprepare(ftide->pclk);
+       clk_disable_unprepare(ftide->pclk);
 
        return 0;
 }