drm/rockchip: inno_hdmi: Don't power up the phy after resetting
authorAlex Bee <knaerzche@gmail.com>
Fri, 22 Dec 2023 17:42:12 +0000 (18:42 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 29 Dec 2023 23:38:30 +0000 (00:38 +0100)
inno_hdmi_reset is only ever called when initializing the controller. At
this point it’s completely uneccessary to power up the PHY, since all
what has to work at this point is the DDC bus. The phy will be powered up
correctly when a mode is set in inno_hdmi_encoder_enable and disabled in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231222174220.55249-22-knaerzche@gmail.com
drivers/gpu/drm/rockchip/inno_hdmi.c

index fbf73f6..763d617 100644 (file)
@@ -201,7 +201,7 @@ static void inno_hdmi_reset(struct inno_hdmi *hdmi)
        val = v_REG_CLK_INV | v_REG_CLK_SOURCE_SYS | v_PWR_ON | v_INT_POL_HIGH;
        hdmi_modb(hdmi, HDMI_SYS_CTRL, msk, val);
 
-       inno_hdmi_set_pwr_mode(hdmi, NORMAL);
+       inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR);
 }
 
 static void inno_hdmi_disable_frame(struct inno_hdmi *hdmi,