btrfs: send: simplify return logic from send_link()
authorFilipe Manana <fdmanana@suse.com>
Thu, 20 Feb 2025 10:57:57 +0000 (10:57 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Mar 2025 19:35:46 +0000 (20:35 +0100)
There is no need to have an 'out' label and jump into it since there are
no resource cleanups to perform (release locks, free memory, etc), so
make this simpler by removing the label and goto and instead return
directly.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/send.c

index d5c1516..bda229c 100644 (file)
@@ -833,7 +833,7 @@ static int send_link(struct send_ctx *sctx,
 
        ret = begin_cmd(sctx, BTRFS_SEND_C_LINK);
        if (ret < 0)
-               goto out;
+               return ret;
 
        TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH, path);
        TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH_LINK, lnk);
@@ -841,7 +841,6 @@ static int send_link(struct send_ctx *sctx,
        ret = send_cmd(sctx);
 
 tlv_put_failure:
-out:
        return ret;
 }