bus: mhi: core: remove redundant initialization of variables state and ee
authorColin Ian King <colin.king@canonical.com>
Thu, 11 Mar 2021 11:17:27 +0000 (11:17 +0000)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Mon, 15 Mar 2021 04:26:07 +0000 (09:56 +0530)
The variables state and ee are being initialized with values that
are never read and are being updated later with a new values. The
initializations are redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210311111727.8433-1-colin.king@canonical.com
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/core/main.c

index 2c61dfd..3faf8ba 100644 (file)
@@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
 {
        struct mhi_controller *mhi_cntrl = priv;
        struct device *dev = &mhi_cntrl->mhi_dev->dev;
-       enum mhi_state state = MHI_STATE_MAX;
+       enum mhi_state state;
        enum mhi_pm_state pm_state = 0;
-       enum mhi_ee_type ee = MHI_EE_MAX;
+       enum mhi_ee_type ee;
 
        write_lock_irq(&mhi_cntrl->pm_lock);
        if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {