staging: rtl8723bs: place constants on the right side of tests
authorSevinj Aghayeva <sevinj.aghayeva@gmail.com>
Wed, 30 Mar 2022 12:07:09 +0000 (08:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 05:33:48 +0000 (07:33 +0200)
Adhere to Linux kernel coding style.

Reported by checkpatch:

WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Link: https://lore.kernel.org/r/20220330120709.GA339788@euclid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme.c

index ed2d3b7..d5bb3a5 100644 (file)
@@ -792,7 +792,7 @@ void rtw_surveydone_event_callback(struct adapter   *adapter, u8 *pbuf)
                        set_fwstate(pmlmepriv, _FW_UNDER_LINKING);
                        pmlmepriv->to_join = false;
                        s_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
-                       if (_SUCCESS == s_ret) {
+                       if (s_ret == _SUCCESS) {
                             _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT);
                        } else if (s_ret == 2) {/* there is no need to wait for join */
                                _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
@@ -1554,7 +1554,7 @@ void _rtw_join_timeout_handler(struct timer_list *t)
                                int do_join_r;
 
                                do_join_r = rtw_do_join(adapter);
-                               if (_SUCCESS != do_join_r) {
+                               if (do_join_r != _SUCCESS) {
                                        continue;
                                }
                                break;
@@ -2558,7 +2558,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr
                issued = (phtpriv->agg_enable_bitmap>>priority)&0x1;
                issued |= (phtpriv->candidate_tid_bitmap>>priority)&0x1;
 
-               if (0 == issued) {
+               if (issued == 0) {
                        psta->htpriv.candidate_tid_bitmap |= BIT((u8)priority);
                        rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra);
                }
@@ -2610,14 +2610,14 @@ void _rtw_roaming(struct adapter *padapter, struct wlan_network *tgt_network)
        struct wlan_network *cur_network = &pmlmepriv->cur_network;
        int do_join_r;
 
-       if (0 < rtw_to_roam(padapter)) {
+       if (rtw_to_roam(padapter) > 0) {
                memcpy(&pmlmepriv->assoc_ssid, &cur_network->network.ssid, sizeof(struct ndis_802_11_ssid));
 
                pmlmepriv->assoc_by_bssid = false;
 
                while (1) {
                        do_join_r = rtw_do_join(padapter);
-                       if (_SUCCESS == do_join_r) {
+                       if (do_join_r == _SUCCESS) {
                                break;
                        } else {
                                rtw_dec_to_roam(padapter);