staging: fieldbus: Fix the error handling path in anybuss_host_common_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 22 Apr 2022 06:48:18 +0000 (08:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Apr 2022 14:48:31 +0000 (16:48 +0200)
If device_register() fails, device_unregister() should not be called
because it will free some resources that are not allocated.
put_device() should be used instead.

Fixes: 308ee87a2f1e ("staging: fieldbus: anybus-s: support HMS Anybus-S bus")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/5401a519608d6e1a4e7435c20f4f20b0c5c36c23.1650610082.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fieldbus/anybuss/host.c

index a344410..cd86b9c 100644 (file)
@@ -1384,7 +1384,7 @@ anybuss_host_common_probe(struct device *dev,
                goto err_device;
        return cd;
 err_device:
-       device_unregister(&cd->client->dev);
+       put_device(&cd->client->dev);
 err_kthread:
        kthread_stop(cd->qthread);
 err_reset: