net sched actions: use sizeof operator for buffer length
authorRoman Mashak <mrv@mojatatu.com>
Wed, 27 Jun 2018 17:33:33 +0000 (13:33 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Jun 2018 13:12:03 +0000 (22:12 +0900)
Replace constant integer with sizeof() to clearly indicate
the destination buffer length in skb_header_pointer() calls.

Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_pedit.c

index 9c2d8a3..3b775f5 100644 (file)
@@ -319,7 +319,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
                                        goto bad;
                                }
                                d = skb_header_pointer(skb, hoffset + tkey->at,
-                                                      1, &_d);
+                                                      sizeof(_d), &_d);
                                if (!d)
                                        goto bad;
                                offset += (*d & tkey->offmask) >> tkey->shift;
@@ -337,7 +337,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
                        }
 
                        ptr = skb_header_pointer(skb, hoffset + offset,
-                                                4, &hdata);
+                                                sizeof(hdata), &hdata);
                        if (!ptr)
                                goto bad;
                        /* just do it, baby */