cxl/feature: Remove redundant code of get supported features
authorLi Ming <ming.li@zohomail.com>
Fri, 16 May 2025 14:32:20 +0000 (22:32 +0800)
committerDave Jiang <dave.jiang@intel.com>
Mon, 19 May 2025 15:58:04 +0000 (08:58 -0700)
In cxlctl_get_supported_features(), there is a code block that handles
the case where the requested is equal to 0. But the code following the
code block can also handle this situation. So the code block is not
needed.

Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://patch.msgid.link/20250516143220.35302-1-ming.li@zohomail.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/features.c

index bd51210..2167a8d 100644 (file)
@@ -426,14 +426,6 @@ static void *cxlctl_get_supported_features(struct cxl_features_state *cxlfs,
 
        rpc_out->size = struct_size(feat_out, ents, requested);
        feat_out = &rpc_out->get_sup_feats_out;
-       if (requested == 0) {
-               feat_out->num_entries = cpu_to_le16(requested);
-               feat_out->supported_feats =
-                       cpu_to_le16(cxlfs->entries->num_features);
-               rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
-               *out_len = out_size;
-               return no_free_ptr(rpc_out);
-       }
 
        for (i = start, pos = &feat_out->ents[0];
             i < cxlfs->entries->num_features; i++, pos++) {