ACPI: dock: fix some coding style issues
authorXiaofei Tan <tanxiaofei@huawei.com>
Sat, 27 Mar 2021 12:08:24 +0000 (20:08 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 8 Apr 2021 14:27:03 +0000 (16:27 +0200)
Fix some coding style issues reported by checkpatch.pl, including
following types:

WARNING: Missing a blank line after declarations
ERROR: spaces required around that ':'
WARNING: Statements should start on a tabstop

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/dock.c

index 0937cea..7cf9215 100644 (file)
@@ -271,6 +271,7 @@ static void hotplug_dock_devices(struct dock_station *ds, u32 event)
 
                if (!acpi_device_enumerated(adev)) {
                        int ret = acpi_bus_scan(adev->handle);
+
                        if (ret)
                                dev_dbg(&adev->dev, "scan error %d\n", -ret);
                }
@@ -502,6 +503,7 @@ static ssize_t flags_show(struct device *dev,
                          struct device_attribute *attr, char *buf)
 {
        struct dock_station *dock_station = dev->platform_data;
+
        return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);
 
 }
@@ -523,7 +525,7 @@ static ssize_t undock_store(struct device *dev, struct device_attribute *attr,
        begin_undock(dock_station);
        ret = handle_eject_request(dock_station, ACPI_NOTIFY_EJECT_REQUEST);
        acpi_scan_lock_release();
-       return ret ? ret: count;
+       return ret ? ret : count;
 }
 static DEVICE_ATTR_WO(undock);
 
@@ -535,10 +537,11 @@ static ssize_t uid_show(struct device *dev,
 {
        unsigned long long lbuf;
        struct dock_station *dock_station = dev->platform_data;
+
        acpi_status status = acpi_evaluate_integer(dock_station->handle,
                                        "_UID", NULL, &lbuf);
        if (ACPI_FAILURE(status))
-           return 0;
+               return 0;
 
        return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
 }