virtio_balloon: prevent pfn array overflow
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 6 Feb 2020 07:40:58 +0000 (02:40 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 6 Feb 2020 08:40:26 +0000 (03:40 -0500)
Make sure, at build time, that pfn array is big enough to hold a single
page.  It happens to be true since the PAGE_SHIFT value at the moment is
20, which is 1M - exactly 256 4K balloon pages.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
drivers/virtio/virtio_balloon.c

index 8e400ec..2457c54 100644 (file)
@@ -158,6 +158,8 @@ static void set_page_pfns(struct virtio_balloon *vb,
 {
        unsigned int i;
 
+       BUILD_BUG_ON(VIRTIO_BALLOON_PAGES_PER_PAGE > VIRTIO_BALLOON_ARRAY_PFNS_MAX);
+
        /*
         * Set balloon pfns pointing at this page.
         * Note that the first pfn points at start of the page.