ALSA: dice: fix error path for initialization of stream structures
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 29 Aug 2019 14:37:19 +0000 (23:37 +0900)
committerTakashi Iwai <tiwai@suse.de>
Thu, 29 Aug 2019 15:00:37 +0000 (17:00 +0200)
When introducing AMDTP domain to ALSA dice driver, error path does not
handle error correctly. This commit fixes the bug.

Fixes: e9f21129b8d8 ("ALSA: dice: support AMDTP domain")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/dice/dice-stream.c

index af8c5a2..f6a8627 100644 (file)
@@ -570,7 +570,7 @@ int snd_dice_stream_init_duplex(struct snd_dice *dice)
                                destroy_stream(dice, AMDTP_OUT_STREAM, i);
                        for (i = 0; i < MAX_STREAMS; i++)
                                destroy_stream(dice, AMDTP_IN_STREAM, i);
-                       break;
+                       goto end;
                }
        }