leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'

In case of memory allocation failure, we must release some resources as
done in all other error handling paths of the function.

'goto child_out' instead of a direct return so that 'fwnode_handle_put()'
is called when we break out of a 'device_for_each_child_node' loop.

Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index 5fb4f24..f13117e 100644 (file)
--- a/drivers/leds/leds-lp50xx.c
+++ b/drivers/leds/leds-lp50xx.c
@@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
                 */
                mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE,
                                           sizeof(*mc_led_info), GFP_KERNEL);
-               if (!mc_led_info)
-                       return -ENOMEM;
+               if (!mc_led_info) {
+                       ret = -ENOMEM;
+                       goto child_out;
+               }
 
                fwnode_for_each_child_node(child, led_node) {
                        ret = fwnode_property_read_u32(led_node, "color",