gpio: xgene-sb: Don't shadow error code of gpiochip_lock_as_irq()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 30 Jul 2018 12:38:35 +0000 (15:38 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 6 Aug 2018 21:46:55 +0000 (23:46 +0200)
gpiochip_lock_as_irq() may return a few error codes,
do not shadow them by -ENOSPC and let caller to decide.

No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-xgene-sb.c

index acd5911..2eb76f3 100644 (file)
@@ -143,12 +143,14 @@ static int xgene_gpio_sb_domain_activate(struct irq_domain *d,
 {
        struct xgene_gpio_sb *priv = d->host_data;
        u32 gpio = HWIRQ_TO_GPIO(priv, irq_data->hwirq);
+       int ret;
 
-       if (gpiochip_lock_as_irq(&priv->gc, gpio)) {
+       ret = gpiochip_lock_as_irq(&priv->gc, gpio);
+       if (ret) {
                dev_err(priv->gc.parent,
                "Unable to configure XGene GPIO standby pin %d as IRQ\n",
                                gpio);
-               return -ENOSPC;
+               return ret;
        }
 
        xgene_gpio_set_bit(&priv->gc, priv->regs + MPA_GPIO_SEL_LO,