netdevsim: fix fall-through annotation
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 29 Apr 2019 17:38:07 +0000 (12:38 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 May 2019 15:36:55 +0000 (11:36 -0400)
Replace "pass through" with a proper "fall through" annotation
in order to fix the following warning:

drivers/net/netdevsim/bus.c: In function ‘new_device_store’:
drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
   port_count = 1;
   ~~~~~~~~~~~^~~
drivers/net/netdevsim/bus.c:172:2: note: here
  case 2:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This fix is part of the ongoing efforts to enable
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/bus.c

index ae48234..fd68eea 100644 (file)
@@ -168,7 +168,7 @@ new_device_store(struct bus_type *bus, const char *buf, size_t count)
        switch (err) {
        case 1:
                port_count = 1;
-               /* pass through */
+               /* fall through */
        case 2:
                if (id > INT_MAX) {
                        pr_err("Value of \"id\" is too big.\n");