mtd: rawnand: gpmi: remove double assignment to block_size
authorColin Ian King <colin.king@canonical.com>
Tue, 4 Jun 2019 10:58:59 +0000 (11:58 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 27 Jun 2019 18:06:42 +0000 (20:06 +0200)
The variable block_size is being assigned to itself and to
geo->ecc_chunk_size.  Clean up the double assignment by removing
the assignment to itself.

Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c

index 5db8417..334fe31 100644 (file)
@@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data *this)
        struct bch_geometry *geo = &this->bch_geometry;
        unsigned int ecc_strength = geo->ecc_strength >> 1;
        unsigned int gf_len = geo->gf_len;
-       unsigned int block_size = block_size = geo->ecc_chunk_size;
+       unsigned int block_size = geo->ecc_chunk_size;
 
        this->bch_flashlayout0 =
                BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) |