drm/i915/backlight: Modify condition to use panel luminance
authorSuraj Kandpal <suraj.kandpal@intel.com>
Fri, 11 Apr 2025 06:02:36 +0000 (11:32 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Fri, 11 Apr 2025 13:25:26 +0000 (18:55 +0530)
According to our internal spec we need to now check if both
panel luminance and smooth brightness are available in panel for
us to be able to change brightness using luminance value.

--v2
-Add Fixes tag [Ankit]

Fixes: 64481497924d ("drm/i915/backlight: Check Luminance based brightness control for VESA")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://lore.kernel.org/r/20250411060235.2732060-3-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c

index 8173de8..20ab90a 100644 (file)
@@ -663,7 +663,8 @@ intel_dp_aux_supports_vesa_backlight(struct intel_connector *connector)
        struct intel_dp *intel_dp = intel_attached_dp(connector);
        struct intel_panel *panel = &connector->panel;
 
-       if ((intel_dp->edp_dpcd[3] & DP_EDP_PANEL_LUMINANCE_CONTROL_CAPABLE)) {
+       if ((intel_dp->edp_dpcd[3] & DP_EDP_PANEL_LUMINANCE_CONTROL_CAPABLE) &&
+           (intel_dp->edp_dpcd[3] & DP_EDP_SMOOTH_BRIGHTNESS_CAPABLE)) {
                drm_dbg_kms(display->drm,
                            "[CONNECTOR:%d:%s] AUX Luminance Based Backlight Control Supported!\n",
                            connector->base.base.id, connector->base.name);