crypto: caam - warn if blob_gen key is insecure

If CAAM is not in "trusted" or "secure" state, a fixed non-volatile key
is used instead of the unique device key. This is the default mode of
operation without secure boot (HAB). In this scenario, CAAM encrypted
blobs should be used only for testing but not in a production
environment, so issue a warning.

Signed-off-by: Nikolaus Voss <nikolaus.voss@haag-streit.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/caam/blob_gen.c b/drivers/crypto/caam/blob_gen.c
index 6345c72..1f65df4 100644 (file)
--- a/drivers/crypto/caam/blob_gen.c
+++ b/drivers/crypto/caam/blob_gen.c
@@ -6,6 +6,7 @@
 
 #define pr_fmt(fmt) "caam blob_gen: " fmt
 
+#include <linux/bitfield.h>
 #include <linux/device.h>
 #include <soc/fsl/caam-blob.h>
 
@@ -61,12 +62,14 @@ static void caam_blob_job_done(struct device *dev, u32 *desc, u32 err, void *con
 int caam_process_blob(struct caam_blob_priv *priv,
                      struct caam_blob_info *info, bool encap)
 {
+       const struct caam_drv_private *ctrlpriv;
        struct caam_blob_job_result testres;
        struct device *jrdev = &priv->jrdev;
        dma_addr_t dma_in, dma_out;
        int op = OP_PCLID_BLOB;
        size_t output_len;
        u32 *desc;
+       u32 moo;
        int ret;
 
        if (info->key_mod_len > CAAM_BLOB_KEYMOD_LENGTH)
@@ -100,6 +103,12 @@ int caam_process_blob(struct caam_blob_priv *priv,
                goto out_unmap_in;
        }
 
+       ctrlpriv = dev_get_drvdata(jrdev->parent);
+       moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status));
+       if (moo != CSTA_MOO_SECURE && moo != CSTA_MOO_TRUSTED)
+               dev_warn(jrdev,
+                        "using insecure test key, enable HAB to use unique device key!\n");
+
        /*
         * A data blob is encrypted using a blob key (BK); a random number.
         * The BK is used as an AES-CCM key. The initial block (B0) and the

diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h
index 66d6dad..66928f8 100644 (file)
--- a/drivers/crypto/caam/regs.h
+++ b/drivers/crypto/caam/regs.h
@@ -426,6 +426,9 @@ struct caam_perfmon {
        u32 rsvd2;
 #define CSTA_PLEND             BIT(10)
 #define CSTA_ALT_PLEND         BIT(18)
+#define CSTA_MOO               GENMASK(9, 8)
+#define CSTA_MOO_SECURE        1
+#define CSTA_MOO_TRUSTED       2
        u32 status;             /* CSTA - CAAM Status */
        u64 rsvd3;