KEYS: Fix the wrong index when checking the existence of second id
authorChun-Yi Lee <joeyli.kernel@gmail.com>
Wed, 4 Oct 2017 11:18:22 +0000 (19:18 +0800)
committerDavid Howells <dhowells@redhat.com>
Wed, 18 Oct 2017 08:12:40 +0000 (09:12 +0100)
Fix the wrong index number when checking the existence of second
id in function of finding asymmetric key. The id_1 is the second
id that the index in array must be 1 but not 0.

Fixes: 9eb029893ad5 (KEYS: Generalise x509_request_asymmetric_key())
Cc: David Howells <dhowells@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Chun-Yi Lee <jlee@suse.com>
Signed-off-by: David Howells <dhowells@redhat.com>
crypto/asymmetric_keys/asymmetric_type.c

index e4b0ed3..a597f5c 100644 (file)
@@ -105,7 +105,7 @@ struct key *find_asymmetric_key(struct key *keyring,
        if (id_0 && id_1) {
                const struct asymmetric_key_ids *kids = asymmetric_key_ids(key);
 
-               if (!kids->id[0]) {
+               if (!kids->id[1]) {
                        pr_debug("First ID matches, but second is missing\n");
                        goto reject;
                }