drm/sched: Stop setting current entity in FIFO mode
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Wed, 16 Oct 2024 12:20:10 +0000 (13:20 +0100)
committerPhilipp Stanner <pstanner@redhat.com>
Thu, 17 Oct 2024 10:15:11 +0000 (12:15 +0200)
It does not seem there is a need to set the current entity in FIFO mode
since ot only serves as being a "cursor" in round-robin mode. Even if
scheduling mode is changed at runtime the change in behaviour is simply
to restart from the first entity, instead of continuing in RR mode from
where FIFO left it, and that sounds completely fine.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Luben Tuikov <ltuikov89@gmail.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <pstanner@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241016122013.7857-3-tursulin@igalia.com
drivers/gpu/drm/scheduler/sched_main.c

index f2d47b3..28083b0 100644 (file)
@@ -349,7 +349,6 @@ drm_sched_rq_select_entity_fifo(struct drm_gpu_scheduler *sched,
                                return ERR_PTR(-ENOSPC);
                        }
 
-                       rq->current_entity = entity;
                        reinit_completion(&entity->entity_idle);
                        break;
                }