drm/xe/uc: Change assertion to error on huc authentication failure

The fault injection test can cause the xe_huc_auth function to fail.
This is an intentional failure, so in this scenario we don't want to
throw an assert and taint the kernel, because that will impact CI
execution.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patch.msgid.link/20251027214212.2856903-1-zhanjun.dong@intel.com

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 465bda3..40aed4a 100644 (file)
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -218,9 +218,12 @@ int xe_uc_load_hw(struct xe_uc *uc)
 
        xe_guc_engine_activity_enable_stats(&uc->guc);
 
-       /* We don't fail the driver load if HuC fails to auth, but let's warn */
+       /* We don't fail the driver load if HuC fails to auth */
        ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
-       xe_gt_assert(uc_to_gt(uc), !ret);
+       if (ret)
+               xe_gt_err(uc_to_gt(uc),
+                         "HuC authentication failed (%pe), continuing with no HuC\n",
+                         ERR_PTR(ret));
 
        /* GSC load is async */
        xe_gsc_load_start(&uc->gsc);