r8169: disable interrupt source RxOverflow
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 27 May 2024 19:16:56 +0000 (21:16 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 29 May 2024 02:47:24 +0000 (19:47 -0700)
Vendor driver calls this bit RxDescUnavail. All we do in the interrupt
handler in this case is scheduling NAPI. If we should be out of
RX descriptors, then NAPI is scheduled anyway. Therefore remove this
interrupt source. Tested on RTL8168h.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
Link: https://lore.kernel.org/r/9b2054b2-0548-4f48-bf91-b646572093b4@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index 7b9e048..5c4296d 100644 (file)
@@ -5086,12 +5086,10 @@ static void rtl_set_irq_mask(struct rtl8169_private *tp)
        tp->irq_mask = RxOK | RxErr | TxOK | TxErr | LinkChg;
 
        if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
-               tp->irq_mask |= SYSErr | RxOverflow | RxFIFOOver;
+               tp->irq_mask |= SYSErr | RxFIFOOver;
        else if (tp->mac_version == RTL_GIGA_MAC_VER_11)
                /* special workaround needed */
                tp->irq_mask |= RxFIFOOver;
-       else
-               tp->irq_mask |= RxOverflow;
 }
 
 static int rtl_alloc_irq(struct rtl8169_private *tp)